Skip to content

Fix time parsing ha3dprint#419

Merged
brombomb merged 1 commit intomainfrom
fix-3d-print
Mar 23, 2026
Merged

Fix time parsing ha3dprint#419
brombomb merged 1 commit intomainfrom
fix-3d-print

Conversation

@brombomb
Copy link
Collaborator

No description provided.

@brombomb brombomb requested a review from tavdog as a code owner March 23, 2026 15:18
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue in the ha3dprint app related to parsing the end_time from Home Assistant. The changes ensure that the application correctly interprets the time, handles invalid or default values gracefully, and skips rendering when appropriate, improving the overall reliability and efficiency of the app.

Highlights

  • Time Parsing: The PR fixes an issue with time parsing in the ha3dprint app, allowing it to correctly interpret timestamps and ISO 8601 formatted end times from Home Assistant.
  • End Time Handling: The PR improves the handling of the end_time parameter, which is used to determine when a print job has finished. It now correctly parses timestamp values, and gracefully handles default or invalid end_time values.
  • Skipping Renders: The PR ensures that renders are skipped if the print job finished too long ago, or if the end_time cannot be parsed, preventing unnecessary processing.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The code changes modify the fetch_ha_data function to use as_timestamp for the end_time field and update the main function to handle timestamp values for end_time in addition to ISO string parsing, and to avoid skipping renders when the end time is the default value.

@brombomb brombomb merged commit bdcd7e6 into main Mar 23, 2026
7 checks passed
@brombomb brombomb deleted the fix-3d-print branch March 23, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant